Martijn Visser

Results 193 issues of Martijn Visser

In https://github.com/Deltares/Ribasim/pull/2651 I added basetemp to the test-ribasim-python task to easily find test data. We were already using this for other tasks. Since then I sometimes get Acces is denied...

test
python

https://github.com/Deltares/Ribasim/pull/2664 allowed us to replace existing nodes on `add`. On discussing this over https://github.com/Deltares/Ribasim/pull/2677 we identified the following improvements - [ ] Make a public API for removing nodes. See...

python

See initial discussion in https://github.com/Deltares/Ribasim/pull/2634#discussion_r2420178493 It helps with forward compatibility, but also to avoid forgetting tables like in https://github.com/Deltares/Ribasim/pull/2673.

QGIS

For fast simulations like basic_transient the last progress bar update is before 100%. This looks like it is still in progress. For example: ``` ❯ ribasim .\ribasim.toml ┌ Info: Starting...

core

In the first version of #2653, commit https://github.com/Deltares/Ribasim/pull/2653/commits/a57b8b33ff6a9dc4bd6194eae50b14955f6cd777 it looked for ribasim in the path. If it wasn't there, it would download the version matching `ribasim.__version__` under `platformdirs.user_cache_dir`; `c:\Users\visser_mn\AppData\Local\ribasim\Cache\cli\2025.5.0\ribasim\ribasim.exe`. I...

python

I see this coming back every now and then. Possibly a Pkg bug with git dependencies; our PackageCompiler fork. Details ``` 15:53:41  ✨ Pixi task (build in default): julia --project...

CI/CD

`Basin / state` currently only has `node_id` and `level`. I think we should add the single timestamp that the state represents as well to the results. Since we want to...

python
core

For #2604, address this TODO: https://github.com/Deltares/Ribasim/pull/2604/files#diff-e25c8aa097712a2c5032f50517e8c8f741fe2e90328a22542e6b7e9e016ccf92 To be able to do this I need to wait for a NetCDF exported from FEWS with multiple Basins. This should be available in...

test

Columns: time, node_id, node_type, flow_rate. Currently only implemented for netCDF.

documentation
allocation

Since https://github.com/Deltares/Ribasim/pull/2497 we support NetCDF results. More work is needed to support viewing these results in QGIS: - [ ] iMOD timeseries widget - [ ] QGIS temporal controller /...

QGIS