Ribasim icon indicating copy to clipboard operation
Ribasim copied to clipboard

Remove bundled Makie artifacts

Open visr opened this issue 10 months ago • 1 comments

From v2024.11.0 to v2025.1.0 the ribasim_windows.zip size grew from 230 MB to 313 MB.

We should investigate why and see if we can get it back to the old size. Presumably one of the Manifest.toml updates is responsible for this. The difference is entirely in the number of artifacts that get bundled, share\julia\artifacts\ used to be 10 directories but is now 55. I assume we don't need all those.

visr avatar Jan 20 '25 09:01 visr

Ribasim.jl has a weakdep on Makie.jl, meaning some plotting functions are only loaded if both Ribasim and Makie are loaded. I see the extra artifacts are Makie dependencies, for instance:

Makie -> FFMPEG_jll -> libaom_jll

Makie was already a weakdep during the last release, so I don't know if the new behavior comes from changes in PackageCompiler.jl or julia or something else. The project we are compiling in Ribasim.jl, which doesn't include Makie, so I would expect it to not bundle the Makie artifacts.

EDIT: that wasn't it, see https://github.com/Deltares/Ribasim/pull/2113. Perhaps it is because we build from the root project which does have Makie in it as well.

visr avatar Jan 20 '25 12:01 visr

Re-opening because the workaround of https://github.com/Deltares/Ribasim/pull/2441#issuecomment-3048692162 was now undone (and then some) by adding Plots in #2458. This doesn't mean we should remove Plots, because we need it when building the docs, but we should find a better way to avoid shipping them. Perhaps https://github.com/Deltares/Ribasim/pull/2440 will help, perhaps PackageCompiler fixes. Or we could write a script to remove artifacts that are unnecessarily included and run that after the build as another workaround.

visr avatar Jul 18 '25 15:07 visr