Martijn Visser

Results 193 issues of Martijn Visser

Part of #666, does not automatically build yet or is included in release assets. Supersedes #1298. For this we need to wait on the conda-forge release of Quarto 1.5, which...

**What** Currently it is hard to look into the behavior of LevelDemand when there is excess water, because this information is not directly available in the result. **How** @JvanHouwelingen expected...

allocation

I thought I fixed the sorting issue by updating the sorting functions as described in https://github.com/Deltares/Ribasim/pull/597#issuecomment-1719792565. But this fixed sorting actually exposed as issue fixed in 8bc58952ec5dfe0e4f5efa6d9060c529959be660. That now filters...

performance

Currently only volume is tested in `test_get_value_ptr`, but there are 4 variables total, and recently "level" was broken after adding AD support. This is fixed in https://github.com/Deltares/Ribasim/pull/575 but not yet...

test

I use juliaup and have not set `julia.executablePath`. When I run "Julia: Start REPL" it always starts the default channel from juliaup. If I'm in a directory with a juliaup...

### Checks - [x] I have checked that this issue has not already been reported. - [x] I have confirmed this bug exists on the [latest version](https://github.com/prefix-dev/pixi/releases) of pixi, using...

- Add explanation of callback check - In `usage.qmd`: add explanation of water balance tolerance options (too large error probably indicates error in the code or floating point errors) _Originally...

documentation

`check_water_balance_error` runs on `saveat`, by default once per day. We support writing output for each timestep with ```toml [solver] saveat = 0 ``` For e.g. the HWS model this fails...

core
improvement

Since #1819 our states are cumulative flows, getting further from 0 all the time. This formulation helped the water balance error and mean flows a lot, but came at the...

performance
core

This edge validation error is not correct: ![image](https://github.com/user-attachments/assets/1b6dbf4e-8c98-4ae8-9d18-6fd237f44752) It states a certain edge already exists, but it doesn't. There is another duplicate edge that is already present. If a user...

python
validation
ribasim-nl