Martijn Visser

Results 193 issues of Martijn Visser

Allocating memory during a simulation can be a source of slowness. We do allocate for instance a place for results every `saveat`, but besides that we probably shouldn't allocate much....

performance
CI/CD
core

Currently https://ribasim.org/changelog shows the release notes of all releases, but https://ribasim.org/install only links to the assets of the latest release. Today I had to guide some users on how to...

documentation

Currently only these are read by FEWS: - basin.arrow - flow.arrow We should add concentration.arrow to this list. Ideally substances are automatically picked up, but if this is hard we...

python
Delft-FEWS

As far as I can tell it is working as intended, but I do get a message that there was an error, and this is the stacktrace. ``` 2025-03-20T20:43:11 WARNING...

QGIS

Based on `basin.arrow` ![Image](https://github.com/user-attachments/assets/835f6f6a-0f49-4b7a-b763-6573f904229b)

Delft-FEWS

Only the first few tables here have units: https://ribasim.org/reference/usage.html#results.

documentation

This happens somewhat regularly, that somehow the shape of a dataframe is different sometimes on macOS: ``` FAILED python/ribasim/tests/test_io.py::test_roundtrip - pydantic_core._pydantic_core.ValidationError: 1 validation error for Model Value error, Shape of...

CI/CD

Two new releases of dependencies break the latest release of Ribasim Python. New error on string literal syntax in sqlite 3.49. Fixed in https://github.com/Deltares/Ribasim/pull/2117/commits/951ff5d74089b6dc68540aeff2b00fd064794b79. For now users must `pixi add...

python
dependencies

Currently our docs build take 26 minutes. Our example notebooks take up a lot of that time. They are executed in Python, and then run the core with subprocess starting...

documentation
CI/CD

There are a few errors here. The QGIS plugin seems to be working fine. ``` ✨ Pixi task (test-ribasim-qgis-ui in default): python ribasim_qgis/scripts/run_qgis_ui_tests.py ------------------------------------------------------------------------------- pydev debugger: CRITICAL WARNING: This version...

test
QGIS