Victor Gao

Results 41 comments of Victor Gao

This is something I've been wanting to do for a long time. Although I'm wondering if we still need an official event system or not -- events can now be...

Sorry for the late reply and I welcome this change! You can add your new test cases to https://github.com/move-language/move/tree/main/language/tools/move-cli/tests/sandbox_tests/print_values and run `env UPBL=1 cargo test` to update the .exp files....

@zjhmale thanks for making the update and my apologies for the slow review. I've been quite busy this week but will have a closer look at this in the next...

To be fair, I'm not entirely sure if we should label this as a bug as it doesn't seem too unreasonable to require `Std = "0x1"` in unit tests, at...

@tnowacki we designed our native functions in a way such that they could support generic events relatively easily, but 1. didn't remove the old events (incl. vm implementations and native...

Yeah this is a known bug I'm still investigating. Strangely, the `move-unit-test` executable seems to be showing the correct error messages, making me suspect the problem is in the `move-cli`.

Not sure why the hardhat-tests are failing... Could you try to rebase?

Yeah, this has long been a known issue and hopefully we'll have the bandwidth to tack it in the following days. > I think we should start with exposing API's...

@davidiw my bad, thought this was only a translation of the web page ;) Will have another look at the paper

I took a look at the Move parts (chap 4 & 5) and made some comments (see the annotated pdf below). [whitepaper-chinese-annotated.pdf](https://github.com/aptos-labs/aptos-core/files/9499747/whitepaper-chinese-annotated.pdf)