move icon indicating copy to clipboard operation
move copied to clipboard

Print type tags in Debug::print

Open macalinao opened this issue 2 years ago • 4 comments

Motivation

easier to read

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

WIP

macalinao avatar Jul 18 '22 17:07 macalinao

Incomplete but I'm trying to print strings in Debug-- i need to create some test cases

macalinao avatar Jul 18 '22 17:07 macalinao

I think @vgao1996 (who added the VM debug printing logic IIRC), @runtian-zhou, or @tnowacki will be able to suggest a way to test this.

sblackshear avatar Jul 18 '22 17:07 sblackshear

I don't have a nice suggestion for testing this at the moment. IIUC the debug printing logic is gated under the testing flag so you definitely can perform a one-shot testing by using --features testing for cargo. I'm not sure how to write a persistent unit test for this. Maybe @vgao1996 may have a better clue?

runtian-zhou avatar Jul 19 '22 22:07 runtian-zhou

Sorry for the late reply and I welcome this change!

You can add your new test cases to https://github.com/move-language/move/tree/main/language/tools/move-cli/tests/sandbox_tests/print_values and run env UPBL=1 cargo test to update the .exp files. This should also take care of your existing test failure.

vgao1996 avatar Jul 20 '22 19:07 vgao1996

Is this still active?

wrwg avatar Aug 21 '22 01:08 wrwg

Is this still active?

No

macalinao avatar Sep 02 '22 15:09 macalinao