move
move copied to clipboard
[hardhat-move] Make the plugin more sophisticated
Motivation
the hardhat-move plugin seems not well constructed (everything is in a single file) before and only support ethereum architecture, so I think a more matured hardhat plugin should be there for more developers to join and growth the whole ecosystem.
Future plan
there still many TODOs need to be done for this plugin:
- a downloader to download
moveexecutables for each concrete version specified inhardhat.config.jsafter there official releases on Github testtask for move contracts build bymoveandasync-movearchitecture- file cache system for eliminating redundant compiling, contracts will only be compiled when it is a brand new contract or the file content has been changed since last build
- unit test and integration test for this plugin
- maybe it's better to move this plugin out from the move monorepo as a standalone repo for further development and maintainence
will look at the test failures and fix them
Hi @vgao1996, I have updated this PR, pls review again. Now the hardhat plugin focus on Ethereum architecture only. And I tried to add unit test for this plugin beside the integration tests in hardhat-example, since we currently use some experimental API like fs.promise which did not comply with ts-node properly, it seems impossible to run test with mocha and chai with it, so I'll leave it right now and may fix it in further update.
@zjhmale thanks for making the update and my apologies for the slow review. I've been quite busy this week but will have a closer look at this in the next few days.