Taku Amano

Results 239 comments of Taku Amano

Errors in the test have been fixed. The content added by this pull request is excluded from the coverage measurement.

@yusukebe Thank you! I too think "ai/size-limit" is cool. Bundle size is certainly the most important. I was hoping in addition to that to be able to check that 'certain...

@sor4chi Thanks for the review!

Hi @markusahlstrand Thank you for your report. This is a known issue and is currently stuck, but there is a pull request. https://github.com/honojs/hono/pull/2911 https://github.com/honojs/hono/pull/2918 I would like to fix it...

Hi @nitedani, Thanks for making the pull request! Referencing internal symbols is a very interesting implementation, but in the main body of the hono we want to ensure that it...

@nitedani Thanks for the answer. I think the test needs to be modified. I don't think ‘`c.res.headers` becomes mutable when `c.res = res`’ is a result that context.ts should guarantee....

The following cases are problems with the code itself. It is not possible to use the `res` after `res.text()` in hono (or any other framework) as response, so I think...

Hi @nitedani, Thanks for your comment. The following branch is the one with tests added to the contents of https://github.com/honojs/hono/pull/3318#issuecomment-2308567803. https://github.com/honojs/hono/compare/main...usualoma:hono:fix/update-context-res As for #3316, I believe this is how it...

@yusukebe OK, mystery solved. Since we test against the branch being merged, we need to take into account the current contents of main. ![CleanShot 2024-09-06 at 22 26 16@2x](https://github.com/user-attachments/assets/3a142407-d6c4-4b68-a829-7f6e41a18f7f) With...

@yusukebe Thank you, LGTM!