Taku Amano
Taku Amano
On Codecov, the coverage results for "coverage/deno-runtime-coverage.lcov" overwrite the results for main, resulting in a lower coverage rate. It would be nice if the results could be merged.
When generating lcov format data from `deno coverage`, some comment lines are incorrectly treated as executable lines, resulting in unnecessary uncovered.  , where the changes made by the pull request are easy to understand.
Hi @yusukebe. Thank you! If you ask me if it's really necessary, I'd say it's a gray area, but I don't think it will reduce maintainability, so it's fine.
Hi @yusukebe. I'm not sure whether this is a really cool feature or just something that makes things more complicated. What do you think?
Hi @yusukebe, Thank you for your response! As you say, describing it as ‘neatly’ might be better. I think the following are two of Hono's core values (there are several)....
According to this PR, we could say that the following policies apply. * Web requests and responses follow web standards * Access to the file system follows the Node.js API
This is a draft of one approach to the following comments. https://github.com/honojs/hono/pull/3516#issuecomment-2415983393