Taku Amano

Results 239 comments of Taku Amano

@gaetan-puleo @yusukebe Thank you! So, let's make it a policy not to add support for the `Component` class for now. I'll leave #2933 (which I implemented a little extra after...

Hi @StuartMoncrieff Thanks for the report! This is certainly a difficult problem. If we resolve this issue naively, there is a possibility that it will be loaded even though it...

The same problem that was fixed below is occurring. https://github.com/honojs/node-server/pull/172 Changing the following will prevent memory leaks. ```diff diff --git i/src/request.ts w/src/request.ts index 61664fb..f5f0f19 100644 --- i/src/request.ts +++ w/src/request.ts @@...

Based on my investigation, I have come to the following conclusion. There is room for adjustment, but I do not believe this is a memory leak in node-server. ### `global.gc`...

Within the scope I verified, explicitly executing `global.gc()` seemed to free the memory. I created a PR that explicitly executes `global.gc()` every N times when the `--expose-gc` and `requestsPerForcedGC` options...

Hi @krzkz94, thanks for your reply! Just to confirm: As shown in https://github.com/honojs/node-server/issues/269#issuecomment-3157022279, the `--expose-gc` flag is required to execute `global.gc()`. Did you run it with this flag? (It wasn't...

I think there's also a way to do it optionally like this, ``` + _signal: abortController.signal, // Do not pass signal ``` Before that, I want to verify operation in...

Hmm, after digging into this for a while, I don’t think this is an actual memory leak. Because of how Undici is implemented, the AbortController objects tend to get promoted...

As a practical workaround for this, I suppose it would be feasible to enable something equivalent via an option. However, I still consider this merely a symptomatic solution, so I'm...