Taku Amano

Results 239 comments of Taku Amano

@gsoulard In `grecaptcha.render`, the reCaptcha changes the behavior by referring to`window.innerWidth`. So we can solve the problem by assigning a value to `window.innerWidth` before calling `grecaptcha.render`. ```javascript window.innerWidth = 512;...

Hi @mrtska Thanks for the report! I wasn't aware of this behaviour in iOS either. I will fix it in #2524.

Hi @yusukebe! Hmmm, I'm sure there are apps that are synchronous and have no problem working without `await`, but if the handlers were asynchronous, I think all middleware would have...

If we could just avoid `async` / `await`, I think we could write the following in the current spec. As far as I tested it on my environment with Bun,...

I think #1689 is an interesting idea, but I am not sure that it is optimized enough to be meaningful in a production environment beyond producing good results in benchmark...

Yes, I think such a change is possible. I think we can accomplish that with the following changes. ```diff diff --git a/src/compose.ts b/src/compose.ts index 56a755b..bf1491f 100644 --- a/src/compose.ts +++ b/src/compose.ts...

Hi @yusukebe! The changes you have indicated here are good ones! It will reduce the amount of code and clarify the intent. https://github.com/honojs/hono/pull/1685#issuecomment-1809252657 However, with this change, the following code...

@yusukebe Ah yes, sorry I didn't mention it; I understood the point about "improved performance when using `await`." So, I fully agree with you about the https://github.com/honojs/hono/pull/1685#issuecomment-1809252657 patch.

Hi @douglasduteil Thanks for your comment. I just wrote the following test, Context seems to be preserved even in inside Suspence as it appears, but are there any cases where...

Yes, let's try a little work. Please wait a moment!