Taku Amano

Results 239 comments of Taku Amano

> `UnknownError` Defining a class that inherits from `Error` seems fine, but I find proper naming tricky. `UnknownError` is indeed “unknown” in the sense that it represents ‘something’ that isn't...

Hi @yusukebe Yes, I agree that defining a class as you suggest has the advantage of being identifiable via `instanceof`. However, (in my opinion) this case is, as the name...

Hi @yusukebe, thank you for your response! My opinion on that point is: “There's no need to distinguish between handlerA and handlerB. If distinguishing becomes necessary, the user should generate...

Hi @JakobJingleheimer, thank you for your feedback. Were you unable to achieve the expected results with the settings described in the documentation? ```ts import { serveStatic } from '@hono/node-server/serve-static' app.use('/static/*',...

Thanks for your reply. As documented, specifying the root (or path) is the standard usage. However, when calling it without arguments, I personally think the default root should be `./`....

Hi @yatsuna827, thanks for your report. I see, that's certainly how it works with the service worker pattern. For the current Hono implementation, I believe the following workaround is appropriate....

I think the following options are available. * Do nothing * Keep it as is, letting users specify it via the `new Hono()` options * Modify the default `getPath()` *...

Hi @yusukebe! What are the real-world problems we need to solve? If the case of returning “206 Partial Content” is almost always serve-static, and if it is assumed to be...

Hi @exoego, Thanks for the reply. > For Hono users on AWS or GCP (not Cloudflare), serving content from object storage (like AWS S3 or GCP Cloud Storage) will be...