Taku Amano

Results 239 comments of Taku Amano

Hi @haochenx, thank you for your comment. Yes, I agree with you. > my workaround is probably the proper way to handle this It would be good to have something...

Hi @haochenx As you say, I think it would be good if I could receive compressed responses from the backend. If there is demand for support for proxy patterns, I...

@haochenx Thanks for your comment! I've made some changes to the header so that it can be adjusted more finely, and created https://github.com/honojs/hono/pull/3589. Would you be willing to review it...

Hi @DavidHavl I think it's a very good implementation! However, I don't think there are many use cases for event emitters in web frameworks in general. The [Websocket example](https://github.com/DavidHavl/hono-event-emitter?tab=readme-ov-file#websocket-example) makes...

Hi @yusukebe, sorry I missed the discussion. I'm catching up now.

I think it's best to consider the final (major release?) changes first. As https://github.com/honojs/hono/issues/667#issuecomment-3234181742 commented, if it's going to end up like this anyway, it's better to do it that...

Ultimately, it depends on the final specification, but existing apps likely operate under the principle of “catching exceptions beforehand if they're not thrown as an Error instance.” Therefore, even if...

I believe there are several ways to do this, but I think it's fine to proceed as follows. ```diff diff --git i/src/compose.ts w/src/compose.ts index b1d4508f..42379ef1 100644 --- i/src/compose.ts +++ w/src/compose.ts...

Ah, but fundamentally, in cases where non-Error objects are thrown, I believe the best practice is to handle them yourself by catching them, rather than relying on `onError`. Given that...

Hi @yusukebe Sorry for not explaining clearly enough. Here's my opinion. > What is an example of handling non-error objects without relying on onError? Suppose there was an app like...