Devin Mullins

Results 74 comments of Devin Mullins
trafficstars

There is a vulnerability associated with this library: https://rustsec.org/advisories/RUSTSEC-2019-0036.html. Perhaps it is worth switching to an alternative?

Oh, the dependency is indirect, via `binary-install`. See #2117.

The `amp-cache-transform` header mapping is [caches.json](https://github.com/ampproject/amphtml/blob/master/build-system/global-configs/caches.json), as [specified](https://github.com/ampproject/amphtml/blob/master/spec/amp-cache-transform.md#request-header) (though I'm open to PRs against the spec). For ease of implementation, this is also [mirrored](https://github.com/ampproject/amppackager/issues/156#issuecomment-436361057) at https://cdn.ampproject.org/caches.json. In practice, AMP Packager...

Thanks for the plugin, Oliver. I'm curious: what is the use case for halting the request but leaving the URL? The only thing I can think of is 403, but...

Good idea. Any specific recommendations for a first implementation? This was partly planned for via the [Updateable interface](https://github.com/ampproject/amppackager/blob/3c190c330cacf17886738a5b82886f41c06a8d2e/packager/certcache/storage.go#L15-L24), but with no configuration mechanism. It's currently hard-coded here: https://github.com/ampproject/amppackager/blob/6a1c7afdb77f4fb54a848e49deccdf5fa01ff76f/packager/certcache/certcache.go#L144

For the OCSP, what is shared between multiple processes is an OCSP response from the CA (a signed 7-day validity period for the cert). Can be examined with `openssl ocsp...

That groupcache fork works for me. The lack of a need for a separate server is clever. IIUC, it doesn't provide a mechanism for peer discovery: the list of peers...

Yeah, autocache seems like it'd fit this case. Agreed that losing the cache key in that rare event is not the end of the world; request coalescing should ensure that'll...

Another random idea: use something like [gokv](https://github.com/philippgille/gokv) to allow a configurable KV store (including those provided by AWS / Azure / Google Cloud). Is this too heavyweight for this one...

I've come across a couple examples on the webs: - https://github.com/Warashi/try-amppackager - https://github.com/oyorooms/deploy-amppackager-aws/ - https://github.com/ampproject/docs/blob/future/platform/lib/routers/packager.js Haven't looked at them in detail yet, so I can't vouch for them, but we...