Devin Mullins

This tool would be most useful if it could distinguish between the various types of payload errors: - invalid UTF-8 - UTF-8 containing U+0000 NULL or a codepoint that [causes...

This just means a new optional toml field next to CertFile/KeyFile.

Thanks @mattwomple! If that example turns out to be helpful to others, we may want to link to it from the README somewhere. FWIW, https://amppackageexample.com/ is using a similar nginx...

Not sure. This seems like it should work. The `failed to parse private key file` error means "I tried parsing all the PEM blocks and none of them looked like...

Alternatively, maybe try this approach for creating a private key: https://github.com/oyorooms/deploy-amppackager-aws/#generating-ecdsa-key-and-csr-refer-this-article

cc @ithinkihaveacat @uskay

This is an interesting idea to pursue, though only if doing so produces valid AMP.

The validator/cache change for unsigned AMP is the most interesting, as it enables the performance benefits on origin that you mention. The bug for that should live outside of amppackager....

Sorry, I think I understand now (correct me if I'm wrong). There's several pieces to this: - update validator & cache to support alternative JS URLs - update amppackager to...

Sorry I missed this. For reference, in Google this was originally added in http://cl/239478133 per http://b/118606783. Since you landed a fix on the optimizer, I think it makes sense to...