Devin Mullins

Hi @joachimroeleveld, thanks for the report. It looks like our install instructions are incompatible with the latest release of Go 1.16. Until we fix it, you can do one of:...

Just a quick note that #494 also includes updating our go.mod to support `go install @latest` (if possible).

https://tools.ietf.org/html/rfc3986#section-3.4 says `query = *( pchar / "/" / "?" )`. Encoding a query string as a path component would extraneously escape `/` and `?`. This seems fine. In addition,...

https://play.golang.org/p/aVV6I6q-mPV demonstrates that `>` in the host goes unescaped. This is definitely in violation of the ABNF for host at https://tools.ietf.org/html/rfc3986#section-3.2.2, and will likely break Link header parsers.

Wow, there's no way to represent a pct-encoded host in Go's url package? That's frustrating. Yeah, I guess a post-processor would work. Are there any other magic characters we need...

URLs get sanitized in a few different places: https://github.com/ampproject/amppackager/blob/73dec5d4648395b1ce47deb9d0065c2c719c8986/packager/signer/validation.go#L16 https://github.com/ampproject/amppackager/blob/73dec5d4648395b1ce47deb9d0065c2c719c8986/packager/signer/signer.go#L384 https://github.com/ampproject/amppackager/blob/73dec5d4648395b1ce47deb9d0065c2c719c8986/transformer/internal/amphtml/urls.go#L54 I need to do an audit of all of these, and hopefully unify some of the code where requirements...

Unfortunately, I'm really far away from being able to prioritize this. My WIP is at https://github.com/twifkak/amppackager/tree/url_escaping. I think the way forward is to implement our own URL parser (for the...

Thanks for the tip. I'm not familiar with parse-url.js but [its test set](https://github.com/ampproject/amphtml/blob/master/validator/js/engine/parse-url_test.js) looks pretty light compared to the branching factor of RFC3986, so I fear it may have some...

Good idea. Not necessary for signed exchanges, so apologies for the late milestone, but it should be an easy fix, so I'll likely get to it sooner (and am happy...

@alin04 Good call. @Gregable Sure. When Google starts improving its error reporting around SXG, one of the error messages will be "malformed HTML" caused by non-idempotency of the PnP function....