Devin Mullins

Probably some hybrid approach. Minimal amount of docs in README.md, that don't need to be updated frequently, and outlink to wiki for as much as possible.

Is there anything left to do on this (besides e2e testing)?

Also, per https://github.com/ampproject/amppackager/pull/296#discussion_r285801253: > Add some tests including `\\"` (escaped backslash followed by unescaped quote) and `\\\"` (escaped backslash followed by escaped quote), to guard against `tokenize` being replaced by...

And maybe https://github.com/ampproject/amppackager/pull/296#discussion_r285801652, if a falsifiable test can be created: > I think if `!inQuotes`, this should be a parse error, per the [tchar definition](https://tools.ietf.org/html/rfc7230#section-3.2.6). I guess returning empty list...

Good catch. I *think* this is not a problem for SXG, because amppkg [adds preload headers](https://github.com/ampproject/amppackager/blob/cc38c5fad40fc603119a298700820b97a4f0c54f/transformer/transformer.go#L194), which should serve two functions: - hinting priority to the browser - hinting recursive...

Yes, I'm open to such a PR. It shouldn't just be domain -- we'll want to limit by path, too. Note that using the transformers for on-origin will likely require...

> Why is there a preload tag for a file that is then immediately loaded? It's a priority hint in the browser. See the devtools screenshots in [the link](https://amp.dev/documentation/guides-and-tutorials/optimize-and-measure/optimize_amp/#optimize-the-amp-runtime-loading) that...

Two options: - Wait for golang/go#19307 to be fixed - Implement a preprocessor that splits on comma, but only after an even number of non-backslash-escaped quotes (being sure to track...

Ah, yes, the PR check should block merging the PR, not mailing it out. The wacky [PR-to-Google](https://github.com/google/copybara/blob/master/docs/reference.md#git.github_pr_origin), [Google-to-GitHub](https://github.com/google/copybara/blob/master/docs/reference.md#git.github_pr_destination) flow should be supported, still.

A small amount of research to be done here, but should be pretty quick. A couple of examples to follow: - https://github.com/qawolf/actions-test/blob/master/.github/actions/create-status-check/index.js, per https://github.community/t/github-actions-as-status-checks/16666/5 - https://github.com/mitchheddles/github-action-status-check, per https://www.google.com/search?q=github+actions+status+checks Alternatively, I...