Devin Mullins
Devin Mullins
One thing that came up in practice was difficulty meeting the "inner = outer" [requirement](https://github.com/ampproject/amppackager/blob/releases/docs/cache_requirements.md) for URLs with pct-encoded chars (such as `https://example.com/index%2ehtml` or `https://example.com/foo%2fbar`): > The signed fallback URL...
Filed https://github.com/Warashi/try-amppackager/pull/3 in the meantime.
This should also include an auto-updating facility (optional, but enabled by default), to allow the deployed amppackager to remain current with AMP Caches' `AMP-Cache-Transform` request header. Additionally, when grabbing the...
More concretely: - At startup, fetch https://cdn.ampproject.org/caches.json, parse it, and store in memory. (Optionally, save to disk cache for faster startup next time.) - Change [transformedidentifier.go](https://github.com/ampproject/amppackager/blob/releases/transformer/transformers/transformedidentifier.go) to allow any id...
I moving this to milestone v6+ because there are no other AMP SXG caches, nor are any imminent to my knowledge. A more long-term approach would be [subresource substitution](https://github.com/WICG/webpackage/blob/master/explainers/signed-exchange-subresource-subtitution-explainer.md), which...
https://docs.docker.com/config/containers/logging/ suggests logging errors to stderr. This may have raised in priority per discussion at #395.
@ampproject/wg-caching for general feedback. Overall, I'm pretty excited about this. I agree that maintenance is the problem to address here. If AMP Optimizer is the place where this code lives,...
Update: The transformer_test error was fixed in one of the "Sync from Google" PRs. The signer_test errors remain.
TODO: Update {go.{sum,mod},vendor} per #394 and do a quick look-see if there are any other easy wins, else close this bug.
The line that adds link rel=preconnect tags is here: https://github.com/ampproject/amppackager/blob/bf061bede4b0280654c25b19fc3cc34e25d13cf0/transformer/transformers/urlrewrite.go#L187 The code: that collects URLs to preconnect is here: https://github.com/ampproject/amppackager/blob/bf061bede4b0280654c25b19fc3cc34e25d13cf0/transformer/transformers/urlrewrite.go#L171-L173 I'm surprised it does anything, because it depends on a...