Tamas Vami
Tamas Vami
Can we do this somehow dynamic? Bc if we extend everywhere then it will be less useful for the 1e case. So what I have in mind is that we...
I'll look into this next. I think if removing https://github.com/cms-sw/cmssw/blob/3a1c8a527b7ee9aa60b520977b7ce2dd0b7f835d/RecoMET/Configuration/python/GenMETParticles_cff.py#L13 doesnt change anything, then it is safe to remove this
ping to @cms-sw/generators-l2 if they have any objections
``` Configuration Error [Config] : Parameter 'ecal_sp_hits_passname' does not exist in list of parameters. ``` we need to have this with a default in the python file
@cjbarton151 how does what you did compare to what @Layan-Sarayra did in `iss1760-light-pipes-ts`, is it the same thing?
And with that we should close this PR. Thanks everybody who contributed in this!
> seriously consider just dropping the event objects back to their old names and using // NOLINT(readability-*) to avoid their names being changed in the future. how about the other...
That's fair, but I really think it's time to generate a new EcalPN anyway (with v15)
> If only for the short-term goal of validating and comparing the v15 Ecal PN. I assume the validations dont require E14 events, if it's a reasonable stats then one...