Tamas Vami

icon indicating a website link cern.ch/tvami icon indicating an email [email protected]

icon company University of California, Santa Barbara icon location Santa Barbara

Results 386 comments of Tamas Vami

Ratio inset for plots in DQM Validation module

I can give a try to testing, do you wanna open a draft PR?

Use central Random Number Seed Service rather than config

This is the same development as I did in https://github.com/LDMX-Software/ldmx-sw/pull/1359/commits/bda6d5c7145d052d7bac36cfc0eb3f8ea2640192 right? If yes, seems easy, I could put this on my todo list.

Use central Random Number Seed Service rather than config

Maybe we should have another issue that's regarding moving ECAL to STL as well, I understand the implementation choice for ecal was somewhat historical.

Use central Random Number Seed Service rather than config

> , I'm also willing have this issue represent both Sure let's do that

Use central Random Number Seed Service rather than config

I also propose to do this after the we have a new release with new golds

Use central Random Number Seed Service rather than config

While @tomeichlersmith moved the simple HCAL reco to this new approach, the "old" one still uses the `TRandom` https://github.com/LDMX-Software/ldmx-sw/blob/trunk/Hcal/src/Hcal/HcalDigiProducer.cxx#L57-L86 Anyway, part 1) with ECAL is done here https://github.com/LDMX-Software/ldmx-sw/pull/1605

Use central Random Number Seed Service rather than config

Part 2) https://github.com/LDMX-Software/ldmx-sw/pull/1614

Use central Random Number Seed Service rather than config

Part 3) is https://github.com/LDMX-Software/ldmx-sw/pull/1615

Use Geant4-object pointer comparisons instead of string-comparisons where possible

So where should this go? And then have a GetProcess for all other kinda processes? It's not clear to me how the proposed snippet gets rid of string comparisons, there...

Use Geant4-object pointer comparisons instead of string-comparisons where possible

Resolved in https://github.com/LDMX-Software/ldmx-sw/pull/1633