cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

FastGenParticleCandidateProducer does not exist

Open Dr15Jones opened this issue 5 years ago • 7 comments

The generator step imports PhysicsTools/HepMCCandAlgos/python/genParticleCandidates_cfi.py which uses a module named FastGenParticleCandidateProducer. That name does not appear anywhere else in CMSSW. The module label genParticleCandidates does appear elsewhere in various python files but it is never associated with any other module type.

It appears that all uses of genParticleCandidates should be removed from configuration files.

Dr15Jones avatar Jul 01 '20 16:07 Dr15Jones

A new Issue was created by @Dr15Jones Chris Jones.

@Dr15Jones, @silviodonato, @dpiparo, @smuzaffar, @makortel can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

cmsbuild avatar Jul 01 '20 16:07 cmsbuild

assign analysis

Dr15Jones avatar Jul 01 '20 16:07 Dr15Jones

New categories assigned: analysis

@santocch you have been requested to review this Pull request/Issue and eventually sign? Thanks

cmsbuild avatar Jul 01 '20 16:07 cmsbuild

I'll look into this next. I think if removing https://github.com/cms-sw/cmssw/blob/3a1c8a527b7ee9aa60b520977b7ce2dd0b7f835d/RecoMET/Configuration/python/GenMETParticles_cff.py#L13 doesnt change anything, then it is safe to remove this

tvami avatar Jun 20 '25 03:06 tvami

cms-bot internal usage

cmsbuild avatar Jun 20 '25 03:06 cmsbuild

ping to @cms-sw/generators-l2 if they have any objections

tvami avatar Jun 20 '25 03:06 tvami

Seems fair, but maybe @mkirsano can provide some additional info about this.

lviliani avatar Jun 20 '25 13:06 lviliani

+analysis

tvami avatar Jul 03 '25 14:07 tvami

This issue is fully signed and ready to be closed.

cmsbuild avatar Jul 03 '25 14:07 cmsbuild