Taylor Salo

Results 511 comments of Taylor Salo

On the peakdet side, I think we will want to do a head-to-head comparison with other physio tools as part of validating the toolbox at some point. Then again, we've...

That makes sense. I'd generally agree that supporting physio in standard workflows is more important than having perfect physio data. On the other hand, at least for some approaches (e.g.,...

Manuel Taso provided some very useful advice recently. Namely, we should only use the weighted-delay approach when vascular crushing is enabled. When the scan _doesn't_ have vascular crushing, this approach...

It looks like I really need to implement the general kinetic model.

SCORE/SCRUB run on the basic CBF results, so instead the options should be: 1. CBF 2. CBF+SCORE/SCRUB 3. BASIL CBF

The good news is that BASIL CBF should be able to handle multi-PLD, Q2TIPS, and PASL without BolusCutOff.

It doesn't look like BASIL can output CBF time series, although the primary output _should_ be the mean CBF, so it's probably not a big deal.

Some more: ``` aslprep/tests/test_cli.py:7 /src/aslprep/aslprep/tests/test_cli.py:7: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html from pkg_resources import resource_filename as pkgrf ../../usr/local/miniconda/lib/python3.10/site-packages/niworkflows/viz/__init__.py:12 /usr/local/miniconda/lib/python3.10/site-packages/niworkflows/viz/__init__.py:12: PendingDeprecationWarning: Niworkflows will be deprecating visualizations in favor...

I don't really understand what a "dummy volume" is in this context, or why dummy volumes are included in the protocol, but this was also brought up by `lucia_sanchez_aranda` on...

Can you expand on where the current physio support is insufficient? The physio section is definitely pretty bare bones at the moment, but I think some specific examples would help...