Taylor Salo
Taylor Salo
It's currently failing in `main`.
I believe it should based on the changes to the filename patterns. However, the main goal of that PR was just to deselect phase data during the data collection step,...
👍 to remove `optcomAccepted` and `optcomeRejected`, but I don't want to remove `optcomDenoised` (though renaming it to just `denoised` might be nice). Based on the issue name I assume that's...
Love it! If we're focusing on the denoised data, then we can even document it like AROMA. For example, we could distinguish between aggressive and non-aggressive denoising, and show how...
It actually turns out that fMRIPrep names the AROMA-denoised files as "desc-smoothAROMAnonaggr_bold.nii.gz". If we want to be consistent with their naming convention, instead of `desc-denoised`, we might want to call...
@jbteves I think you're right! `desc-denoised` is much clearer.
What about outputting the difference images in the CI artifacts, so we could look at those directly and evaluate whether the change is too much more qualitatively?
> Why is SUSAN applied prior to MELODIC and ICA-AROMA in fMRIprep? The [ICA-AROMA manual](https://github.com/maartenmennes/ICA-AROMA/blob/e8d7a5891563aff7ff71375078314c417d32d808/Manual.pdf) says that it must be run that way. Per the manual: > Note that MELODIC...
At the moment it isn't, but I'm hoping to restructure the workflow to accommodate tedana soon. It should be easy enough to drop SUSAN at that point- assuming it doesn't...