Taylor Salo comments

Results 525 comments of


Taylor Salo

Add section to reports that show system info, tedana call and version

Could you copy over the changes to `.circleci/config.yml` from #949 so we can look at the test outputs as well? It'll make it easier to check over the effects of...

[ENH] Create new `datasets` module, with Cambridge dataset included

This is so out-of-date that I think it would be better to start over from scratch than try to update this PR.

[ENH] Remove accepted and rejected outputs

I believe we decided recently that it would be easier to just start over from scratch on this instead of trying to fix up the PR.

Memory issue reported with nonlinear T2* estimation in fMRIPrep

I think they recommended workarounds, but tedana still causes issues for some users. We could automatically switch from nonlinear fitting to log-linear when the low-memory option is enabled, so that...

[ENH] Use JSON for mapping files to groups

Can't remember why I felt this was necessary or why it was paused for the DTM PR, since the DTM PR didn't touch datasets.

Replace release drafter in favor of GitHub release template

Should have been closed by #1024.

Numpy Deprecating `int` and `float` aliases

I think we're in good shape at this point. Going to close this.

Incorporate type hints when possible

Our minimum Python version is now 3.8, so I don't think we need any extra dependencies. I will open a PR adding a checklist to the PR template with things...

Rename common variables and functions

Happy to close this in favor of #919.

Incorrect implementation and/or description of adaptive_mask

Improvements we can make: 1. Define good echo value in adaptive mask based on last good echo for the voxel, rather than the sum of good echoes. - For example,...