Tom Cosgrove

### Suggested enhancement ``` diff --git a/tests/scripts/all.sh b/tests/scripts/all.sh index f70dcd932..f060d42c7 100755 --- a/tests/scripts/all.sh +++ b/tests/scripts/all.sh @@ -1484,7 +1484,7 @@ component_test_default_no_deprecated () { # configuration leaves something consistent. msg "build: make,...

Montgomery multiplication from bignum prototype

18

## Description Extract Montgomery multiplication from the [prototype](https://github.com/hanno-arm/mbedtls/tree/ecp_prototype): https://github.com/hanno-arm/mbedtls/blob/ecp_prototype/library/bignum_core.c#L366-L394. Fixes #6015 ## Status **IN DEVELOPMENT** ## Requires Backporting **NO** ## Requires ChangeLog **NO** ## Todos - [x] The `MPI_CORE(montmul)` and...

Fix incorrect use of mbedtls_ecp_group_id in test_suite_ssl.function

6

`MBEDTLS_SSL_IANA_TLS_GROUP_SECP192R1` and friends are not members of the `mbedtls_ecp_group_id` enum Found by clang's -Wassign-enum Signed-off-by: Tom Cosgrove ## Status **READY** ## Requires Backporting **NO** (not applicable to 2.28)

entropy_poll.c uses the filesystem but isn't guarded with `MBEDTLS_FS_IO`

2

### Summary In most of the library, all filesystem calls (`fopen()`, `fread()` and `fclose()`) are within `#if defined(MBEDTLS_FS_IO)` guards. However, in `entropy_poll.c` there is a version of `mbedtls_platform_entropy_poll()` that uses...

`mbedtls_ssl_handshake_step()` shouldn't return `0` (success) if an invalid context is passed in, in this easy-to-detect way. Doesn't need a ChangeLog entry, as this isn't something that is really visible to...

It is common (especially in PQC, less so in ECC) to accumulate non-canonical results (>= `N`, the modulus), reducing when the value nears the word boundary (the number of limbs...

Bignum: extract core_mul from the prototype

5

## Description Extract MPI_CORE(mul) from the [prototype](https://github.com/hanno-arm/mbedtls/blob/ecp_prototype/library/bignum_core.c#L288-L295). Fixes #6226 ## Status **READY** ## Requires Backporting **NO** ## Todos - [x] The `MPI_CORE(mul)` and its dependencies are taken from the prototype...

A couple of significant changes need to be made to the bignum tests: * The tests for bignum functions should be split into test cases by module (e.g. `bignum_core`, `bignum_mod_raw`,...

Bignum: extract core_sub_int from the prototype

5

## Description Extract MPI_CORE(sub_int) from the [prototype](https://github.com/hanno-arm/mbedtls/blob/ecp_prototype/library/bignum_core.c#L214-L227). Fixes #6231 ## Status **READY** ## Requires Backporting **NO** ## Todos - [x] The `MPI_CORE(sub_int)` and its dependencies are taken from the prototype...

Fix the return values of the aarch64 unroll8_eor_aes_gcm_*_*_kernel functions

1

These aren't currently checked when they are called in cipher_aes_gcm_hw_armv8.inc, but they are declared as returning as size_t the number of bytes they have processed, and the aes_gcm_*_*_kernel (unroll by...