mbedtls icon indicating copy to clipboard operation
mbedtls copied to clipboard

Bignum: extract core_sub_int from the prototype

Open tom-cosgrove-arm opened this issue 3 years ago • 5 comments

Description

Extract MPI_CORE(sub_int) from the prototype. Fixes #6231

Status

READY

Requires Backporting

NO

Todos

  • [x] The MPI_CORE(sub_int) and its dependencies are taken from the prototype and credit is given to Hanno
  • [x] New macros are expanded/removed
  • [x] The legacy functions in bignum.c are calling the new function wherever possible
  • [x] Extensive unit tests are added for all new functions

tom-cosgrove-arm avatar Aug 25 '22 07:08 tom-cosgrove-arm

Based on #6083 like the others. Needs unit tests and possibly using in the existing code

tom-cosgrove-arm avatar Aug 25 '22 07:08 tom-cosgrove-arm

Now ready for review. This is based on top of the montmul PR #6083. The actual work in this PR is the last 4 commits.

tom-cosgrove-arm avatar Aug 25 '22 10:08 tom-cosgrove-arm

Rebased on top of the montmul PR 6083, which has had a doc comment fix applied. Still the actual work in this PR is only the last 4 commits.

tom-cosgrove-arm avatar Aug 25 '22 15:08 tom-cosgrove-arm

Rebased on top of the latest montmul PR 6083. The actual work in this PR is only the last 4 commits.

tom-cosgrove-arm avatar Sep 13 '22 09:09 tom-cosgrove-arm

Oops, forgot that we're removing the mbedtls_ prefix from the test case names, so added another commit to do that.

This PR is based on the latest montmul PR 6083. The actual work in this PR is only the last 5 commits.

tom-cosgrove-arm avatar Sep 13 '22 09:09 tom-cosgrove-arm

Since https://github.com/Mbed-TLS/mbedtls/pull/6083/commits is merged, please rebase.

gilles-peskine-arm avatar Oct 14 '22 15:10 gilles-peskine-arm

Now ready for (re-)review; uses the updated python test framework

tom-cosgrove-arm avatar Nov 22 '22 15:11 tom-cosgrove-arm