mbedtls icon indicating copy to clipboard operation
mbedtls copied to clipboard

Bignum: extract core_mul from the prototype

Open tom-cosgrove-arm opened this issue 3 years ago • 5 comments

Description

Extract MPI_CORE(mul) from the prototype. Fixes #6226

Status

READY

Requires Backporting

NO

Todos

  • [x] The MPI_CORE(mul) and its dependencies are taken from the prototype and credit is given to Hanno
  • [x] New macros are expanded/removed
  • [x] The legacy function in bignum.c (mbedtls_mpi_mul_mpi()) is calling the new function wherever possible
  • [x] Extensive unit tests are added for all new functions

tom-cosgrove-arm avatar Aug 24 '22 15:08 tom-cosgrove-arm

Unit tests added; this is now ready for review

tom-cosgrove-arm avatar Aug 24 '22 16:08 tom-cosgrove-arm

Rebased on top of montmul, which has had review comments applied. Still the actual work in this PR is only the last 3 commits.

tom-cosgrove-arm avatar Aug 24 '22 17:08 tom-cosgrove-arm

Rebased on top of the montmul PR https://github.com/Mbed-TLS/mbedtls/pull/6083, which has had a doc comment fix applied. Still the actual work in this PR is only the last 3 commits.

tom-cosgrove-arm avatar Aug 25 '22 09:08 tom-cosgrove-arm

Rebased on top of the montmul PR 6083, which has had a doc comment fix applied. Still the actual work in this PR is only the last 3 commits.

tom-cosgrove-arm avatar Aug 25 '22 15:08 tom-cosgrove-arm

This is now rebased on top of the latest montmul PR 6083. The actual work in this PR is still just the last 3 commits.

tom-cosgrove-arm avatar Sep 13 '22 10:09 tom-cosgrove-arm

Since https://github.com/Mbed-TLS/mbedtls/pull/6083/commits is merged, please rebase.

gilles-peskine-arm avatar Oct 14 '22 15:10 gilles-peskine-arm