Tom Cosgrove comments

Results 228 comments of


                                            Tom Cosgrove

Add Montgomery conversion and high level I/O

That's great! Note that with the merging of #6070 _remove radix from test data_ I will be rebasing my PR on top of development, so you'll need to re-do the...

Add the new modulus and the residue structures with low level I/O operations

@yanesca I doubt I'm going to see anything else for now, so consider this review pass complete

Add the new modulus and the residue structures with low level I/O operations

@gabor-mezei-arm are you looking at the CI failures?

Add the new modulus and the residue structures with low level I/O operations

I don't have any more comments on things as they are

[Backport 2.28] Add tests for mbedtls_ecp_set_zero

Should the CI have failed on `all_u16-test_ref_configs`?

Validation remove change pk

What's happening about ChangeLog?

Validation remove change pk

@Zaya-dyno Why have you force-pushed this?

Montgomery multiplication from bignum prototype

Rebased on top of latest development, to get the radix removal from .data files, and with unit tests fully done. Remaining is to update legacy functions to use the new...

Montgomery multiplication from bignum prototype

@yanesca Not sure what we want to do about ChangeLog. The TLS 1.3 folks planned a single ChangeLog entry to cover multiple PRs, which I think is something we might...

Montgomery multiplication from bignum prototype

Other than ChangeLog (see comment above) this is ready for review now