Return an error from mbedtls_ssl_handshake_step() if neither client nor server

Open tom-cosgrove-arm opened this issue 3 years ago • 0 comments

mbedtls_ssl_handshake_step() shouldn't return 0 (success) if an invalid context is passed in, in this easy-to-detect way.

Doesn't need a ChangeLog entry, as this isn't something that is really visible to the user of the library, it is "just" better representing what a function finds of its inputs (in the same way we have MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED)

Fixes #6305

Status

READY

Requires Backporting

NO - 2.28-LTS already returns an error (specifically MBEDTLS_ERR_SSL_FEATURE_UNAVAILABLE) in this case, so this could be considered to be a regression.

Sep 21 '22 11:09 tom-cosgrove-arm