Travis Finkenauer
Travis Finkenauer
- `master` branch is not really used, new development should go into `next` branch (#1759) - Changing the size of a field in `cs_insn` is an ABI break, meaning a...
> `cs_isn.bytes` size is internal only no ? why it would break the API ? `cs_insn` is in `capstone.h`, which is a public header. Changing the `bytes` field changes the...
> The length changing of `bytes` was the reason that Capstone has to bump from 4 to 5 (see [#1315 (comment)](https://github.com/capstone-engine/capstone/issues/1315#issuecomment-458441705)), maybe it's better to consider a solution instead of...
> no, you should not refer to private struct, but just rely on whatever you have in capstone.h. To elaborate, if you rely on a private parts of any library,...
I'd be happy to help, in particular with "organization-level" items like the branching strategy in #1781. I maintain the [Rust language bindings](https://github.com/capstone-rust/capstone-rs).
My proposed branching strategy is to "support" branches: - `next`: contains all active development/new features - old version "vN" branches (`v2`, `v3`, ...) - deprecate `master` branch Guidelines: 1. All...
@aquynh could you change the default branch to `next`? I see several PRs were mistakenly opened against `master`. https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-branches-in-your-repository/changing-the-default-branch
> Thanks for PR, can you provide a test case and give a more detailed explanation about this pr? The `RegNo > 13` check above guarantees that `RegNo != 13`....
also, per #1781 the `next` branch should be used instead of `master`
It looks like Capstone is trying to build for i386, but you don't have the needed i386 libraries. Capstone fixed this issue with #1260. At this point, 3.0.5rc2 (a pre-release)...