Travis Finkenauer

Results 71 comments of Travis Finkenauer

Aside from my comments, I may want to wait to merge this until #143 is merged since that's a big change and there would be conflicts. @Lancern do you have...

> The BPF arch added in this PR looks good and it should be easy to merge it with my PR. If you decide that this PR lands after my...

Thanks for the PR! I'll do some minor clean-up myself

Did some minor clean-up w/ 38bbcce944e42a44638f99489b669f4516cd7001

> Currently, for many supported architectures, their `RegId` and `InsnGroupId` (some architectures even the `InsnId`) are simply defined as a bunch of `u32` values inside a mod rather than a...

> On the other side, if we generate newtype enums for these two underlying C enums, we can easily convert an `Arm64Sysreg` into an `Arm64Reg` by manually implementing a `From`:...

Thanks for jumping in with the contribution! I'll follow up with some review comments.

> I think the if cfg! is kinda weird and should probably rather have it just gate the entire function instead? Anyway, I'm not sure how to handle `assert!(len

> Also @tmfink, whats the current status on the project? Seems like it's missing some updates? I could possibly step in and try and get things up to date. I'll...

> > Also @tmfink, whats the current status on the project? Seems like it's missing some updates? I could possibly step in and try and get things up to date....