Travis Finkenauer

> > Yes, rustc actually applies RUSTC_WRAPPER. > > No it doesn't. If you grep the compiler sources for RUSTC_WRAPPER you won't find any hit. I accidentally typed `rustc` instead...

Actually, after some more investigation, I don't think a `cargo` change alone is enough (without some very hacky changes) since the expectations of `cargo`'s `RUSTC_WRAPPER` and `rustdoc`'s `--test-builder` are different....

> Another idea could be to have a `--test-builder-args` that get prepended before rustdoc's generated args, that'd also be helpful for my [`cargo-rustdoc-clippy`](https://github.com/Nemo157/dotfiles/blob/047bf00a8513321809df2d6fc356754e72dbf858/bin/cargo-rustdoc-clippy) script to be able to not have...

I updated the PR to add the `--test-builder-wrapper` argument as discussed--it's ready for review. Is there some documentation that should also be updated?

@GuillaumeGomez I add docs for `--test-builder`/`--test-builder-wrapper` with d02e66ddf0f1b0d436b3a8374479ec8efbe4b1db

Windows CI is now failing: https://ci.appveyor.com/project/tmfink/capstone-rs/builds/47561178/job/qo9ytbm3mogqwp8r ``` Build started git clone -q https://github.com/capstone-rust/capstone-rs.git C:\projects\capstone-rs git fetch -q origin +refs/pull/142/merge: git checkout -qf FETCH_HEAD Running Install scripts if "%TARGET%" == "i686-pc-windows-gnu"...

> On second thought, we could always just use the minimal api instead of a uniform one, which would not require Peekable here. What do you think? @PSeitz What do...

> Maybe just renaming the type to `AccessType` is a good solution? I agree--that makes sense to me. The C type is name `cs_ac_type`, which does not imply anything about...

> this will break all bindings. Yes. I didn't clarify, but this should not be merged to any other branch. Since the API needed to be updated, I figured I'd...

@fotisl thanks for the comments, my responses are inline: > I don't agree with some of the changes. For example, all information on the functional unit where the instruction is...