Travis Finkenauer comments

Results 71 comments of


                                            Travis Finkenauer

regs_write() and regs_read() do not return complete results

@vn-ki Thanks for the proposals. My thoughts after thinking for a few days: * Approach 1: transparent to user - easier for user - requires extra run-time checks based on...

Exposing `Insn::detail` to the public API

I need to think about it more, but it's possible that it would be safe for `Capstone` to implement `Send` (move to completely new thread) but I **don't think** it...

Support cs_disasm_iter

This is a big improvement over the last PR. :smile: Overall, I like the approach of having separate type to "own" the `cs_insn` allocation. I also like how `DisasmIter` tracks...

Support cs_disasm_iter

I just pushed a fix (#116) for the GitHub action failure; please rebase to the current `master` branch to get the fix.

Support `cs_disasm_iter`

> any progress on this? - I don't see any benefit in support `cs_malloc()` - I tried to implement a wrapper around `cs_disasm_iter()` in non-awkward way, but consistently got issues...

`fn get_context() -> &'static mut` is unsound

I was going to file an issue but saw this issue was already filed. :smile: I'm using macroquad for a personal project (thanks for a great project by the way!)...

`fn get_context() -> &'static mut` is unsound

I think I have a way forward. We can use the `RacyCell` idiom [described in a proposal to deprecate `static mut`](https://github.com/rust-lang/rust/issues/53639#issuecomment-790091647). Playground link https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=c22ec400b8fbdf72a0ef5808106b818b We need to use pointers instead...

`fn get_context() -> &'static mut` is unsound

Per my comment in #368, it would likely take a lot of work to fix the underlying soundness issues in macroquad. There are also other `static mut` variables that likely...

arm64: cs_arm64_op sys field can be arm64_sys_op OR arm64_reg but is defined as arm64_sys_op

@adamjseitz nice analysis. Here are the permalinks: Old way (`v4` branch): https://github.com/capstone-engine/capstone/blob/0efa3cc530ea188c0e03c945ab884ee19dd16342/arch/AArch64/AArch64InstPrinter.c#L1612 New way (`next` branch currently): https://github.com/capstone-engine/capstone/blob/ba2199042700e6bda2e0069e924370a7b2530ac0/arch/AArch64/AArch64InstPrinter.c#L2152 Currently in the `next` branch, if the operand is `ARM64_SYSREG_DBGDTRRX_EL0`, `ARM64_SYSREG_VSCTLR_EL2`, or...

Registration to crates.io

This would be great, since your crate would be easier to discover (also easier to use in a project). https://lib.rs/keywords/japanese