Tim te Beek

hi @punkratz312 ; sounds like a fine case for a recipe indeed to put at least a single blank line before the first statement in a class body. Having that...

Thanks for the report @punkratz312 ! Would you happen to recall which recipe made that exact change? Since CodeCleanup is an aggregate it takes me a while to rerun it...

There's indeed a bit of unfortunate "here be dragons" to that ChangePropertyKey. From a [quick search](https://github.com/search?q=org%3Aopenrewrite%20%22org.openrewrite.yaml.ChangePropertyKey%22&type=code) it appears that rewrite-spring is unique in using the _yaml_ ChangePropertyKey. The properties variant...

Thanks for reporting this variant! To detect sub classes you can either expand this loop https://github.com/openrewrite/rewrite-static-analysis/blob/2163f0f05dd6fe7f4762e3486c8f16a9a5787036/src/main/java/org/openrewrite/staticanalysis/FinalClassVisitor.java#L72-L83 Or add a `new JavaIsoVisitor() { ... }` that overrides `visitClassDeclaration`, and visit on...

Thanks both! Fixed just now in - #742

The associated fix made it into 2.19.0, with the test added in https://github.com/openrewrite/rewrite-static-analysis/commit/6d6fe5e495330d851e1c8257270263337b994a02 Is there any change you can make to the test to reproduce the issue you're seeing?

That helps, thanks! I've pushed up another change in https://github.com/openrewrite/rewrite-static-analysis/commit/c195a4ff79d01c7b147eab35f49fbf211c00b3a3

> JDK 23 will be released later this month, so perhaps worth looking into. (My schedule is packed the coming weeks, so unfortunately I won't have time to dive in...

- Now also tracked at: https://github.com/openrewrite/rewrite/issues/4513 - And likely fixed in https://github.com/openrewrite/rewrite/pull/4516 We'll do another release this Wednesday; should help to see if this worked. :)

> Updated the PR; build should pass once [openrewrite/rewrite#4618](https://github.com/openrewrite/rewrite/pull/4618) is released. I've just released https://github.com/openrewrite/rewrite/releases/tag/v8.38.1 ; That's on top of yesterday's https://github.com/openrewrite/rewrite-templating/releases/tag/v1.16.3 Do let me know how those work out...