Tim Deschryver
Tim Deschryver
@AdrianRomanski are you willing to address the remaining feedback?
That would be awesome @paweltwardziak !
> @timdeschryver see #4515 I've updated prefer-protected-state.md in that PR as well - I am not sure whether or not this is something acceptable to mix a little PR responibilities....
Hi @amakhrov , I think that would be a great addition. If you want, feel free to create a PR for this.
Go for it @markoblagdan
Woops, sorry @rainerhahnekamp I missed that during my initial review.
@rainerhahnekamp can we close this PR in favor of a new issue to upgrade the full ESLint stack (angular eslint, eslint, ts eslint, ...) when there's a Angular ESlint v19?
@mumenthalers that's a valid point, and something I was also thinking. This is something we can do for the next major release. Thanks for your input, it's appreciated!
That's a call you can make, for the NgRx docs we added a note about NgModules with a reference to the archived docs (e.g. https://v17.ngrx.io/docs). For now we can also...
Thank you for bringing this up and opening a PR @GavynHolt!