platform icon indicating copy to clipboard operation
platform copied to clipboard

docs(effects): update examples to standalone api

Open AdrianRomanski opened this issue 1 year ago • 4 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://github.com/ngrx/platform/blob/main/CONTRIBUTING.md#commit
  • [x] Tests for the changes have been added (for bug fixes / features)
  • [x] Documentation has been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #4468

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

AdrianRomanski avatar Sep 11 '24 15:09 AdrianRomanski

Deploy Preview for ngrx-io ready!

Built without sensitive environment variables

Name Link
Latest commit f83eb49ce1550015c08eadd5729fb595b10f1993
Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/675764427202bf0009c30e67
Deploy Preview https://deploy-preview-4522--ngrx-io.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Sep 11 '24 15:09 netlify[bot]

@ timdeschryver

i pushed first changes :) Tommorrow i will do the remaining

AdrianRomanski avatar Sep 13 '24 15:09 AdrianRomanski

@AdrianRomanski are you willing to address the remaining feedback?

timdeschryver avatar Oct 08 '24 16:10 timdeschryver

@timdeschryver yes, i will sit to this straight after the office

AdrianRomanski avatar Oct 09 '24 06:10 AdrianRomanski

Thanks @AdrianRomanski!

markostanimirovic avatar Dec 09 '24 22:12 markostanimirovic