platform icon indicating copy to clipboard operation
platform copied to clipboard

docs: update example app to standalone

Open sheikalthaf opened this issue 1 year ago • 9 comments

Updated the example app to standalone, removed all the modules from app.

PR Checklist

Please check if your PR fulfills the following requirements:

  • [ ] The commit message follows our guidelines: https://github.com/ngrx/platform/blob/main/CONTRIBUTING.md#commit
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Documentation has been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

sheikalthaf avatar Aug 08 '24 01:08 sheikalthaf

Deploy Preview for ngrx-io canceled.

Built without sensitive environment variables

Name Link
Latest commit 6312a4cbf2e4dd88dfab0dce317d4b2888d57a97
Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/66f9bbb4a45b4600087484de

netlify[bot] avatar Aug 08 '24 01:08 netlify[bot]

Hey, looks like we have a duplicate for this: #4417. Was there a second issue, or should I assign @sheikalthaf to it?

rainerhahnekamp avatar Aug 08 '24 14:08 rainerhahnekamp

@rainerhahnekamp it was assigned to you, so you still have first choice.

brandonroberts avatar Aug 08 '24 15:08 brandonroberts

@sheikalthaf, please keep in mind the contribution guide (https://github.com/ngrx/platform/blob/main/CONTRIBUTING.md).

We usually open an issue and assign it to you. Only then should you submit a PR. Otherwise, multiple developers will be working on the same task.

In this case, I am going to assign the issue to you, but please check the issues first for the next one.

Please add a short comment in #4417, so that I can select you from the user list.

Thanks!

rainerhahnekamp avatar Aug 08 '24 16:08 rainerhahnekamp

@rainerhahnekamp thanks for pointing out. sorry I don't know about that. From next time I'll check the issue comments clearly. Sorry for the confusion here.

sheikalthaf avatar Aug 08 '24 17:08 sheikalthaf

Woops, sorry @rainerhahnekamp I missed that during my initial review.

timdeschryver avatar Aug 08 '24 19:08 timdeschryver

@timdeschryver this is the only testcase is failing and i see that the snapshot is wrong. Can you help me here image

sheikalthaf avatar Aug 12 '24 17:08 sheikalthaf

@rainerhahnekamp and me going to work together on this PR. For now I'm making this as a Draft until the pipeline is fixed. @rainerhahnekamp currently linting is failing, can you help me here.

@timdeschryver FYI

sheikalthaf avatar Aug 12 '24 17:08 sheikalthaf

@sheikalthaf yup, I will check

rainerhahnekamp avatar Aug 12 '24 17:08 rainerhahnekamp

FYI. I've applied a lot of updates to the example app, likesignals, input/output, standalone control flow, inject etc.

It has currently some errors but as soon as Nx 20 with the final eslint config has been merged, I am going to fix this PR as well.

rainerhahnekamp avatar Nov 17 '24 18:11 rainerhahnekamp

I'm going to close this PR. Feel free to reopen it when the update of example-app to standalone APIs is ready.

markostanimirovic avatar May 17 '25 21:05 markostanimirovic