platform
platform copied to clipboard
feat(eslint-plugin): upgrade typescript-eslint to stable v8
PR Checklist
Please check if your PR fulfills the following requirements:
- [x] The commit message follows our guidelines: https://github.com/ngrx/platform/blob/main/CONTRIBUTING.md#commit
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Documentation has been added / updated (for bug fixes / features)
PR Type
typescript-eslint 8 has been released in a stable version. This PR update from alpha to stable.
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[x] Other... Please describe: Dependency update
Closes #
Does this PR introduce a breaking change?
I'm not sure if an upgrade from alpha to stable counts as a breaking change. I would have said no. Angular-eslint did a minor release.
[ ] Yes
[x] No
Deploy Preview for ngrx-io canceled.
Built without sensitive environment variables
| Name | Link |
|---|---|
| Latest commit | 09be518ebea40ae6f37971f9ba3b56a29c857dcc |
| Latest deploy log | https://app.netlify.com/sites/ngrx-io/deploys/66b9bb9669c6b6000822d6f6 |
[nitpick] Title should probably say v8 (not v9) 😄
Putting back to draft because of a failed build. Looks like it is not "just" an npm i
@rainerhahnekamp can we close this PR in favor of a new issue to upgrade the full ESLint stack (angular eslint, eslint, ts eslint, ...) when there's a Angular ESlint v19?
Yes of course.