Tim Deschryver

Results 249 comments of Tim Deschryver

Do you find the information you need in the docs? https://angular-auth-oidc-client.com/docs/documentation/custom-storage

For now I think it's fine to keep it as is. If we migrate, I think it's better to skip jest, and use Vitest.

We'll take a look at this. The typing could be simplified, which we'll tackle in a different PR.

I have to disagree with this one. TypeScript can infer the generic automatically, I think using generics for this can also lead to breaking changes in the future when we...

The same comment of https://github.com/ngrx/platform/issues/4753#issuecomment-2819072621 applies to this issue as well.

I will take a look at this in the next days (I might push directly into this branch). AFAIK @MichaelDeBoey is right about the reasons of why not to include...

@eps1lon does this seem good to you? As mentioned in the comments, `@babel/helper-compilation-targets` was pinned to make the build happy without upgrading deps/changing the browserlist support (as was done in...

You can login before your test suite is run and store the authentication state so it can be reused while running your tests. Shameless plug: https://timdeschryver.dev/blog/revamped-authentication-with-playwright