Tim Deschryver

Results 249 comments of Tim Deschryver

> Interesting finding with the new vitest which is default in Angular v21 is how `configureTestingModule` works with non-standalone components: [angular/angular#66007](https://github.com/angular/angular/issues/66007) [angular/angular#65665](https://github.com/angular/angular/issues/65665) > > It means that the current implementation...

Hello, sorry this is a bit too narrow. If you want you can create a pull request with an integrating AG-grid, and I can give some feedback

> Hi @timdeschryver would love also your feedback here. Just a couple issues then I think it's good to go. Thank you. I will take a look at it later...

> > The remaining CI errors are not caused by this PR => they should be resolved in #5044. > > There are 2 errors that's related to vitest uncaught...

@exequiel09 could you pull the latest main branch into your branch please? This should resolve the remaining errors.

> I just rebased the PR just moments ago based on the latest commits on the main branch. Did something change again or got merged? Thanks 👍 You can ignore...

I wanted to answer on this issue, but I forgot about it. The example on the page shows what is desired, but doesn't mention why. As you already mentioned, we...

@mcpierce sorry for my late response. This rule is to prevent memory leaks that are creating from store subscriptions. Using the `async` pipe instead prevents this. The provided example can...

@colinhacks thanks Colin. Unfortunately, I don't have the bandwidth to update the library right now. If someone wants to help out, feel free to add a comment here.