Tim Abbott
Tim Abbott
Removing chat.zulip.org review, since I think the next step for this is to try an alternative design for where the button goes. One option that would at least be cheap...
Thanks for working on this @catherjh! It certainly looks less broken; can you explain your thinking around the positioning for the error elements and the design more generally? Also, is...
Yes -Tim Abbott (mobile) On Wed, Nov 17, 2021, 11:30 Alya Abbott ***@***.***> wrote: > @timabbott for the tooltips, should we be > using tippy here? > > — >...
Thanks for working on this @Sarah-Addo! I posted a few comments; it'd also be great if you can clean up the commit history (possibly by squashing the commits; I haven't...
This PR has very messy commit history, but the code looks reasonably organized and it we might be a useful resource for finishing this issue.
I stacked this into #28478 since I think we want to merge the changes together, dropping the semi-duplicate commit.
@pedroiralmeida thanks for working on this! It looks like a nice chunk of work. I posted some initial implementation comments; I think there's a good chance we can work this...
Playing with this, why does the "Scale to fit" button immediately save changes? I would have expected it to just do a cropping action. I'm also not really sure what...
Sorry for the delay. The strategy looks reasonable; posted a few comments on implementation readability. I think in any case the next step is to test-deploy on chat.zulip.org for UX...
Deployed on chat.zulip.org!