Tim Abbott
Tim Abbott
Closing as we've added the relevant transactions since then.
Due to a GitHub bug, my comments ended up on https://github.com/akshatdalton/zulip/commit/f90589e7b9730e0482a4ba35c7636e5e7c265677.
I can't really review this without your undoing all the paragraph-wrapping changes that it appears your editor did automatically. So probably you should do a rebase of this, and then...
One possibility is that the test is nondeterministic; another is that its result depends on the test order. `test-backend foo --parallel=1` and `test-backend foo --parallel=1 --reverse` can help debug.
@garg3133 ping on whether you've had a chance to try the debugging technique suggested above. We're getting close to the 5.0 release and I kinda want to get all known...
@garg3133 did we somehow lose track of integrating this, or did it get finished via another PR?
I did some fiddling with this, and pushed the results back here. Still needs work; here's my proposal: * We rename the existing `RealmDeactivatedError` class to `RealmDeactivatedAuthenticationError`, in the backend...
I merged the first commit and pushed back here. I was able to get into these states by resizing the window while viewing settings and then toggling the checkbox (one...
@sahil839 would you be up for reviewing this?
@alya thoughts on this? I kinda think we might be better off putting those items inside a hamburger menu than shrinking them, especially since the strings could be longer when...