Tim Abbott

Results 1313 comments of Tim Abbott
trafficstars

I merged the 3 prep commits as the series ending with 6b255fcc147f39b4b94554e1b4e67c143fb695a9.

I posted a fairly complete set of reviews from reading the code; I've not done any manual testing, which is probably a good priority for others, especially around testing that...

This looks good to me. I'm not entirely sure we have the perfect version of the strings; flagging the tooltip: ![image](https://github.com/user-attachments/assets/4b938cfd-6e82-4a85-954e-c19dc652cf8f) I'm also not entirely sure about the API error...

I think probably we should keep the API design and strings as-is; after reviewing the "Prevent ..." strings, I think a better resolution is going to be to change the...

Merged, thanks for all the work on this @tnmkr and @Ujjawal3! @alya may want to do a quick pass on the help center and other wording before this makes it...

The implementation looks good, but this is an API change and needs to be documented as such. Started https://chat.zulip.org/#narrow/stream/378-api-design/topic/deleting.20messages.20when.20not.20subscribed/near/1842975 to discuss the change.

Closing in favor of https://github.com/zulip/zulip/pull/30927 for this issue.

I don't see any response to the discussion about whether we need to use `stream_topic_history_util.get_server_history` in https://github.com/zulip/zulip/pull/29191#discussion_r1645212648. Maybe you can comment on your thinking on that here, since it's hidden...

> I apologize for the for not responding. Your comments were displayed in the upper portion of the screen, which caused me to overlook them unintentionally. I regret that this...

I pushed an updated version of this PR that addresses I think all of my feedback above. I need to manually test a bit, and then we can deploy on...