zulip icon indicating copy to clipboard operation
zulip copied to clipboard

bottom_whitespace: Show buttons to navigate to next unread narrow.

Open amanagr opened this issue 3 years ago • 14 comments

This will allow users to easily navigate unread content and increase use of n and p hotkeys. Screenshot 2021-11-13 at 2 45 11 PM

Fixes #18728

amanagr avatar Nov 13 '21 09:11 amanagr

A few comments from playing around with this PR:

  1. The tippy tooltips are too invasive -- they pop up quickly, are very noticeable, and the user generally doesn't need them. Can we switch to regular tooltips, the way we have for the "New topic" and "New private message" buttons? I think those will be significantly less in the way.

  2. It annoying to have the button jump around depending on how many messages are in the topic you just navigated to. You really want it to be consistently in the same place if so that you can keep clicking it without having to move the mouse up and down. Can we figure out a way to place it just above the compose box even if the topic only has a message or two you are looking at?

  3. I don't love how the buttons look, though I do appreciate that the aren't as bright as the initial version. Perhaps we should discuss in #design?

  4. Currently, in the interleaved stream view the buttons are not shown but the n key works. Unless it's too complicated to show the buttons from a technical perspective, this probably merits a #design conversation as well.

Sorry I missed this PR earlier!

alya avatar Nov 23 '21 19:11 alya

I just had the thought that we should make sure something reasonable happens if you're viewing a stream you aren't subscribed to, which has a "Subscribe" button in a similar location.

alya avatar Nov 24 '21 21:11 alya

Also, for visual consistency, we should probably have these buttons look the same/similar to the "Subscribe" button.

alya avatar Nov 24 '21 21:11 alya

I suppose we can update this now that we've merged the Spectators version of this feature?

timabbott avatar Feb 01 '22 20:02 timabbott

Yes.

amanagr avatar Feb 02 '22 05:02 amanagr

Screenshot 2022-03-28 at 9 33 53 PM Screenshot 2022-03-28 at 9 34 05 PM Screenshot 2022-03-28 at 9 34 18 PM Screenshot 2022-03-28 at 9 34 25 PM Screenshot 2022-03-29 at 3 41 52 PM Screenshot 2022-03-29 at 4 04 32 PM Screenshot 2022-03-29 at 4 12 04 PM

amanagr avatar Mar 29 '22 10:03 amanagr

@alya FYI this is ready for your review after you are free from 5.0 work.

amanagr avatar Mar 29 '22 12:03 amanagr

I'm test-deploying this on chat.zulip.org.

timabbott avatar Apr 18 '22 20:04 timabbott

The template language is called Handlebars, not “handlebar”.

I just saw this button show up at the bottom of the All messages view with no unread messages, so it may not be getting updated at all the right times.

andersk avatar Apr 18 '22 21:04 andersk

@amanagr can you update this to address the above feedback and post a summary of its status? I'd like to try getting it deployed on chat.zulip.org again.

timabbott avatar Jul 28 '22 18:07 timabbott

Rebased.

I just saw this button show up at the bottom of the All messages view with no unread messages, so it may not be getting updated at all the right times.

Fixed. Thanks!

amanagr avatar Aug 02 '22 15:08 amanagr

I merged the first commit, and will be deploying this on chat.zulip.org shortly.

timabbott avatar Aug 03 '22 23:08 timabbott

Heads up @amanagr, we just merged some commits that conflict with the changes you made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

zulipbot avatar Aug 04 '22 00:08 zulipbot

Removing chat.zulip.org review, since I think the next step for this is to try an alternative design for where the button goes.

One option that would at least be cheap to try is just putting "Next unread topic" in the left sidebar under "Drafts" and see how that works.

timabbott avatar Aug 07 '22 03:08 timabbott