Tim Abbott
Tim Abbott
The following I think resolves my feedback above: ``` diff diff --git a/web/src/message_list_view.ts b/web/src/message_list_view.ts index 21d1112897..32a493ca78 100644 --- a/web/src/message_list_view.ts +++ b/web/src/message_list_view.ts @@ -394,21 +394,19 @@ function populate_group_from_message( const sub =...
I made those edits plus a few more linting fixups. With those changes, this lgtm. Thanks for all the work on this @opmkumar, @kennethnrk and @sahil839!
This looks great, merged, thanks @abdelrahman725 and @karlstolley!
Cool, this does seem very much worth doing!
Merged, thanks @alexmv!
@Niloth-p can you review this?
I'm pretty sure you can just pip install it; it's just easier to write instructions that can make assumptions about the paths where everything lives; it'll be more fiddly with...
https://github.com/zulip/python-zulip-api/issues/636 and the discussion linked from there is probably helpful.
I'm gonna leave this open, since we do want to improve the tooling/documentation here.
Merged, after some more rewriting of the docs and moving the documentation commit to the end. Can you do some end-to-end testing of this end result and post about it...