Joyjit Daw

Results 190 comments of Joyjit Daw

Done for banded Myers implementation, but Hirschberg still uses old API that doesn't cap memory from the API itself

Hi @kountaydwivedi - the setup instructions for GenomeWorks are described in https://github.com/clara-parabricks/GenomeWorks#genomeworks-setup . Are you interested in using the C++ APIs or python APIs?

Hi @kountaydwivedi - we don't install our binaries/libraries into any default system location. The easiest to add the binary to your path would be (on Ubuntu e.g.) `export PATH=$PATH:`. We...

Consider using https://www.sphinx-doc.org/en/master/usage/advanced/setuptools.html instead of raw sphinx commands

Also consider adding more custom exception types for each binding to deal with their specific errors. Then update the documentation, tests and samples accordingly to highlight the proper usage of...

This was intended for the metrics calculation classes. From what I recall there's a conditional in every metrics class that checks for whether or not the input array is numpy...

Hi @lh3 - we have another [patch](https://github.com/nanoporetech/ont-minimap2/blob/master/src/patches/0003-Make-mm_tbuf_t-struct-public.patch) to get access to the `rep_len` attributes in the thread buffer structure. Would you be open to accepting that as well?

the following structure may make sense - 1. a common set of "filters" are registered with the LabelLoader class 2. the `LabelLoader` implementations create a `Variant` tuple out of each...

After giving this some more thought with @ohadmo we realized that label filtering can become a pretty big effort if it was to be done well, and it's not really...