Tommy Hofmann

Results 702 comments of Tommy Hofmann

another stupid question: this sound like reinventing serialization/deserialization without all the safety guarantees? Edit: I heavily use `Eltseq` in Magma, because I find the "Serialization" in Magma lacking and to...

Tell me if you found a way to track down the 1.10 -> 1.11 regression. For Hecke it is even worse: ``` julia> @time @eval using Hecke # 1.10 [...]...

I would be in favor of moving this to `ConformanceTests` for now.

I think your comments reveal that it is not clear what `is_known` will be used for. In the context here, it seems that `is_known` is becoming part of the interface...

I don't consider it a problem that all elements are identical.

flint does not have this interface function. At the moment we do an `is_gen(x, i)` check for all i, but this is too slow when repeated 200 times. Not sure...

Yes, one can do this. It is the same logic as https://github.com/flintlib/flint/blob/726ee2d3f8e85cee82627a45a8a85d4bff482025/src/mpoly/is_gen.c. To call `mpoly_get_monomial_ffmpz`, one would have to pass `fmpz *`, but this is a bit cumbersome to do...

What about the `Hecke.build_doc()`/`Oscar.build_doc()` way? Just wondering what you mean when you say "rolled out to perhaps some more of our repos". Do we want two slightly different ways for...

Without Revise support I have a hard time imagening how doing `julia docs/make.jl` (which is what this PR here adivses?) is better than `*.build_doc()`. Can you just add the Revise...

(There is no official way to get `A` and `B` out of `Union{A, B}`, see https://github.com/JuliaLang/julia/issues/53193. There is `Base.uniontypes`, but this is not inferable. There is some handcrafted alternative in...