Tommy Hofmann
Tommy Hofmann
Test error is ``` Test Failed at /home/runner/work/Nemo.jl/Nemo.jl/oscar-dev/Oscar/test/Rings/integer.jl:357 Expression: Int(ZZ(typemin(Int)) - 1) Expected: InexactError No exception thrown ``` which indeed should throw I think.
To make sure that ZZ and QQ construct things of the right type, but it appears we then added some more.
I probably misunderstood something, but `base_ring` is not part of the ring interface. How can a missing `base_ring` method make the conformance tests fail?
Thanks for the clarification. I am also happy to help with missing methods.
First hopefully fixed by https://github.com/oscar-system/Oscar.jl/pull/4903.
@fieker Here is the example, condensed to the failing `is_irreducible` call: ``` julia> Qx, x = QQ[:x]; julia> R, s = QQ[:s]; julia> K, q = number_field(s^2 - 2, "q");...
Fixed with new Hecke version
Looks good, but we have to put it in the next breaking release I think.
Do we want to rush in a new breaking release before Oscar 1.6?
I have mainly questions about `similar` (which is becoming part of the interface, since `similar` is exported by default?): - Will this be the official way to create new ideals?...