Tommy Hofmann

Results 702 comments of Tommy Hofmann

I had hoped that this would be https://github.com/oscar-system/Oscar.jl/issues/2543, but this does not seem to be the case?

@benlorenz I see a slightly larger memory usage on julia nightly than on julia 1.9 for this example from the doctst. Not sure this explains the observation in OP.

Before looking at this more closely, I wanted to ask what the overall aim of this is? If it is just about reducing the necessary functions in the matrix API,...

The "linear combination" path is failing for ``` julia> Qx, x = QQ[:x]; julia> K, a = number_field(x^8 - x^4 + 1, :a); julia> Hecke._subfield_primitive_element_from_basis(K, [sqrt(K(2)), sqrt(K(3))], true); Sieving for...

Error from the tests: ``` julia> Qx, x = QQ[:x]; julia> K, a = number_field(x^8 + 1040*x^6 + 345784*x^4 + 39199680*x^2 + 545876496, :a); julia> b = [K(1), 1//70976*a^6 +...

It seems that for many values of `n, m` the following is fine, but then for this specific values it is hanging/taking a very long time: ``` julia> n, m...

I am not convinced that the gain (less code?) outweighs the increase in memory consumption. I think @fieker had some ideas of consolidating the series code, but I don't remember...

It should be an error. The method should be removed.