Sebastian Falbesoner

I agree with @furszy and @mzumsande that a `getblockfileinfo` RPC could be quite handy, both for making some of the pruning-related tests more robust and readable (potentially eliminating some magic...

FWIW, I was curious how hard it would be to implement `getblockfileinfo` in the functional test framework by parsing the block files: https://github.com/theStack/bitcoin/blob/97ea647ee9b186ff4d3be2ba5ac91b94e5371323/test/functional/test_framework/util.py#L559-L584 (branch https://github.com/theStack/bitcoin/tree/getblockfileinfo_python) The result seems to work,...

Rebased on master, CI should be green now (there was a silent merge conflict in the benchmark due to a change in the `COutPoint` ctor interface, see #28922).

> Does this reduce our safety against memory corruption or similar? I don't think so, at least I don't see how verifying a created signature twice in a row has...

Rebased on master, which was necessary due to the removal of `ECC_{Start,Stop}` from the key header in #29252. The `ECC_Context` RAII wrapper is used now instead (like done in commit...

Concept ACK, thanks for picking this up.

> I switched to the `Popen` constructor that accepts `const std::string&` instead of `std::vector` to address quoting issues on Windows. > > @theStack Since you initially chose to use a...

Concept ACK

> Concept ACK! i think flaky tests are possible because disconnection could happen before [`p2p_conn.wait_for_connect()`](https://github.com/bitcoin/bitcoin/blob/7699a1aab8fa2a7a602391025f3cfcde29ff2613/test/functional/test_framework/test_node.py#L728) in `add_outbound_connection()`? True, good catch. The flaky case can be reproduced by adding an artificial...

Solved the [flaky test issue](https://github.com/bitcoin/bitcoin/pull/29279#pullrequestreview-1844051383) by introducing a `wait_for_disconnect` parameter to `add_p2p_outbound_connection`, which hits the same code path as for feeler connections if set (i.e. waiting for immediate disconnect).